AUHistoryHint

[Solonor]

Originally Posted by redsoxford

Commas in text fields inside CSVs are a pain. I think OOTP does stick quotes round text fields but that changes the method of parsing the strings.

I could probably do a similar thing using the .dat files directly. Maybe I should have a word with Larry to see what sort of things he's pulling out and how it could be done with my direct access methodology.

If it's the "Jr" problem, then does no one have "Ken Griffey, Jr." in their league running this util? Or are all the Junior's set up in the game without commas?

[Comedian2004]

Yep, the comma is the problem.

When I parse a field, I first turn all the commas into semi-colons. So, that comma becomes a semi colon, so his record will have an extra field.

I can't think of a way around it, but I will look at it and see.

I am assuming the comma is in the actual name of the player, as part of their last name. What database did you use?

Just remove the comma from the name in the game, or after you do the dump, remove the comma from the name in the players.csv file.

I have done many historical seasons and never came across that, so I am assuming that since I use the Lahman database, you muse be using another that has added the comma. Whoever created the database needs to change that, as you cannot have a comma or a semi-colon in a field, as either one of those can be used as CSV dump delimiters. Markus originally had a comma in the nickname field when a player went by more than 1 nickname. When I TT'd it, he just eliminated the 2nd nickname instead of changing it to a dash, like I suggested.

For me to change my code to look for a jr. would be too much work, as every program that accessed that file would have to be changed, then it would also have to check for other names:

, jr.
, sr.
, stupid,
,M.D.

Be easier to REMOVE THE DAMN COMMA!

[Solonor]

Originally Posted by Comedian2004

Yep, the comma is the problem.

When I parse a field, I first turn all the commas into semi-colons. So, that comma becomes a semi colon, so his record will have an extra field.

I can't think of a way around it, but I will look at it and see.

I am assuming the comma is in the actual name of the player, as part of their last name. What database did you use?

Just remove the comma from the name in the game, or after you do the dump, remove the comma from the name in the players.csv file.

I have done many historical seasons and never came across that, so I am assuming that since I use the Lahman database, you muse be using another that has added the comma. Whoever created the database needs to change that, as you cannot have a comma or a semi-colon in a field, as either one of those can be used as CSV dump delimiters. Markus originally had a comma in the nickname field when a player went by more than 1 nickname. When I TT'd it, he just eliminated the 2nd nickname instead of changing it to a dash, like I suggested.

For me to change my code to look for a jr. would be too much work, as every program that accessed that file would have to be changed, then it would also have to check for other names:

, jr.
, sr.
, stupid,
,M.D.

Be easier to REMOVE THE DAMN COMMA!

No sweat. I can fix that. Thanks for the info.

I'm not using a specific roster set. These are fictional players created by the game using names we have put in the names dat files.

In Lahman, they don't use the "Jr" designation as part of the name. Ken Griffey, Jr., is in there as nameFirst = Ken, nameLast = Griffey, and nameGiven = George Kenneth (Jr.).

I wonder why it never bothered any of your other programs?

Anyway, thanks for this utility. I have spent the last few weeks coming up with league-specific hints, but it's been tedious, and it's nearly impossible to calculate streaks and such manually.

[Neags23]

I think "The Lil Evil Eye Bug" is the coolest named bug I've ever heard of, though.

[targy]

So what is causing the ID2 problem

[Comedian2004]

The ID2 section deals with the games.csv file and the games_score files.

Looking at the code, I have it pretty tight for error checking. There must be something weird.

What month is your season in. Have you deleted or added any teams after the league started?

[targy]

No changes but the new season is starting and I ran a dump and the problem goes away...I will tell you what month it starts to happen again if it does. I am just simming this season and will go back to managong next season

[targy]

Ok I ran the program at the beginning of May with no problems...I will try it again as the season progresses and then when I become the manager again and see it that was the problem

[Comedian2004]

That actually makes sense to me. When you run the program before the start of the season, but after the pre-season starts, there is some funky data out there because OOTP does not properly clean up last year's files.

So, all of the game box scores exist, but the CSV files do not match the actual files. As the games.csv file is based on this year.

The ID2 section is mainly used for the stuff like, most runs scored in the 5th inning, etc. So, at this point of the season, there are none. There could be spring training games, but they are ignored.

That is why I have the debug section to shut off the different ID sections when they error. You simply shut it off and try again later in the season.

I personally think the best time to run the program is at the end of the season, before you cross over into the new year. You then get tons of information about your 'last year', and then when June arrives, you run it again and then you get a lot of information based on this year.