The XML Suggestion Thread (June 15 XML File Version)

[M's rule]

Originally Posted by tysok

158-9482 spanks a hot shot on the ground straight up the middle
199-14212 Adelio Crespa will have to hurry
219-8830 through into center for a hit

Crespa is their third baseman, he has to do more than hurry to get a hot grounder back up the middle.

The problem seems to be that the game doesn't associate [%game groundball location] (straight up the middle) with the [%game fielder] who will make the play--although it is in sync with [%game ball direction] (center).

If this is flaw is widespread, I suspect we'd be seeing lots of examples of it, and of its converse (middle infielders going for grounders hit down the line). Maybe it's only a problem when [%game groundball location] = "straight up the middle."

[M's rule]

Originally Posted by tysok

14-32 Beechey goes to third...
Beechey is is trying to score...
Beechey is not challenged with a throw...
he scores...

The 2nd line is is not right.
Although, doesn't look like that whole section should be 14-32... but that's what it says.

The second, third, and fourth lines are not from the XML file. I will report the "is is" problem.

In the debug output, a line is preceded by numbers only if it is the first line of an object from the XML file. Lines that are not preceded by numbers are either continuations of the current object, or text that is not pulled from the XML file. The only way to tell one from the other is to look up the object in the XML file and see exactly what it consists of.

[M's rule]

Originally Posted by tysok

280-10320 440 on the tape measure...
Nathan Beechey delivers a 3-runhome run...

Should have a space between 3-run and home run


Next one:
---hit softly in the air on the right side
241-12276 MacGlashin (1B) is under it...
Barrlos (CF) is also after it...
but he's waved off by MacGlashin

The fast CFer again.

Next one:
189-11368 the batter takes a cut...
166-6591 check swing...

He either takes a cut or checks his swing... announcer is confused cuz he's watching a different game on the monitor.

Any line that says how many runs scored on a homer is coded in the game. I will report the missing space.

Next one:
A variation on the earlier reported problem, I think.

Next one:
"check swing" is the first part of a long message. I fixed this problem by deleting that text from the entry. I found other examples of the same problem and took care of them as well. If the fact that a swing took place is dealt with in an earlier message (which seems to be the case), then the message that gives the result of the play shouldn't also mention the swing. Good catch.

[M's rule]

Originally Posted by Zeyes

Didn't see it mentioned in this thread or the older one...

I noticed that some news stories were missing words (player/personnel names, in particular). Looking at the XML, the problem for several of these cases was that the tokens were missing the % sign, so I've hunted down as many broken tokens as I could find. Here we go...

[35-2085] [subleagueabbr]
[40-1338] [batting h word]
[40-1864] [batting rbi]
[42-4582] [personname L]
[46-1916] [batting avg]
[46-5121] [batting bb]
[48-4705] [Personname L]
[51-2063] [teamname nick]
[52-4622] [batting d word]
[53-1705] [rookieaward]
[93-1120] [leagueyear]
[118-3679] [playerposition abbr]
[118-3680] [playerposition abbr]
[118-3682] [playerposition abbr]
[118-3684] [playerposition abbr]
[118-3685] [playerposition abbr]
[118-3686] [playerposition abbr]
[118-3697] [playerposition abbr]
[118-3705] [playerposition abbr]
[118-3716] [playerposition abbr]
[118-3721] [playerposition abbr]
[124-2262] [batting t word]
[124-2274] [batting r word]
[124-2333] [batting h word]
[124-2563] [batting rbi]
[125-2354] [pitching ra word]
[125-5263] [pitching ra word]
[132-3415] [personname F L]
[132-3438] [personname L]
[132-3442] [personname L]
[134-3381] [personname L]
[134-3398] [personname F L]
[172-8397] [game outs+2 order]
[209-9895] [game outs+1]
[209-9901] [game outs+1]
[360-14084] [game base1]
[380-14837] [personname l]
[380-14838] [personname l]
[380-14839] [personname l]
[380-14840] [personname l]
[380-14841] [personname l]

---

Not sure if the next one breaks anything, but I guess they're not supposed to have thoses spaces after and before the bracket, respectively:

[305-10429] [ %game fielder2]
[167-11115] [%game secondbase ]

---

An oddity:

[165-5837] "routine grounder...(nl)right side of the diamond...(nl)[%game firstbase] moves in quickly...(nl)makes the easy pickup...(nl)waves off the pitcher...(nl)and tags the base to retire [%game batter]...(nl)[%game outs+1 long] away in the [%game teamab] [fifth]."

I guess there's supposed to be a token for the current inning where [fifth] is currently?

---

Not a token problem, but they showed up in my search for square brackets, so here are various buggy (nl) tags:

[nl):
[245-14301]
[245-14316]

(nl]:
[106-2800]

[n]:
[60-4747]

(n]:
[260-12594]

(n):
[129-4354]
[166-6580]
[177-7986]
[313-10435]
[344-10708]
[344-10758]
[348-14488]

---

wrong opening bracket:

[111-4778] ]%personlink]
[173-10113] ]%game outs+1 long word]
[173-10129] ]%game outs+1 long word]

---

doubled closing bracket:

[169-11180] [%game outs+1 long]]

---

And finally, missing spaces around tokens:

[39-215] Reliever[%personname F L]
[113-4501] [%teamlink nickonly]are
[164-5858] [%game catcher]reaches
[167-11055] [%game outs+1 long]down
[167-11077] [%game batter]is
[172-8409] [%game secondbase]fires
[173-10085] [%game leftfield]ranges

Zeyes, thank you for the good detail work. I'm embarrassed that I didn't think to search the database for "[" followed by something other than "%"--but all those errors are now fixed.

I also tended to everything else in your post that hadn't already been spotted.

[Matter2003]

TextID: 13928
Cat:Foul_Without_Swing

Error: "Good effor though"
-missing the 't' at the end of effort...

[jbsnadb]

I was hoping to just play a game without being nit-picky

Pop-up to the catcher...

[241-14686] camps under the ball...

The player name is missing.

[jbsnadb]

POY News Item:

[92-1304] ...He has driven in 38 runs batted in...

"Driven in" implies RBI, making the "runs batted in" redundant. "Runs" alone would be acceptable, so it could either read:

"He has driven in 38..."
or
"He has driven in 38 runs..."

[M's rule]

Originally Posted by Matter2003

TextID: 13928
Cat:Foul_Without_Swing

Error: "Good effor though"
-missing the 't' at the end of effort...

Already fixed. KUTGW.

[M's rule]

Originally Posted by jbsnadb

I was hoping to just play a game without being nit-picky

Pop-up to the catcher...

[241-14686] camps under the ball...

The player name is missing.

This message was already deleted, so the problem has gone away.

[M's rule]

Originally Posted by jbsnadb

POY News Item:

[92-1304] ...He has driven in 38 runs batted in...

"Driven in" implies RBI, making the "runs batted in" redundant. "Runs" alone would be acceptable, so it could either read:

"He has driven in 38..."
or
"He has driven in 38 runs..."

Fixed just now, along with a couple of other problems in that message. Thanks.

[jbsnadb]

This is less an error than an omission:

There is a 3-HR in a game news item that utilizes the following text lines:

[24-2834]
and
[92-1261]

While there are no errors in the text, the hitter's HR totals for the season are nowhere to be found. Seems like an item ABOUT home runs should mention how many home runs this guy has hit over the season.

[tysok]

I think it's time for a new xml file, or at least send one to jbsnadb and me... at this point I think we just find problems that we've already found, or overlook ones that may be similar because we think we've already found that one.

I've stopped looking for now for that reason. But on the other hand, I am just simply enjoying the game and finding other bigger problems to keep the beta team happy.

[battists]

I'll get Marc to post a new one.

It might be Monday though.

[M's rule]

Originally Posted by battists

I'll get Marc to post a new one.

It might be Monday though.

Steve, please check your PMs if you haven't done so recently.

[M's rule]

Originally Posted by jbsnadb

This is less an error than an omission:

There is a 3-HR in a game news item that utilizes the following text lines:

[24-2834]
and
[92-1261]

While there are no errors in the text, the hitter's HR totals for the season are nowhere to be found. Seems like an item ABOUT home runs should mention how many home runs this guy has hit over the season.

What happens is, the game calls up a news message from category 24 (game news three homeruns) when someone has a 3-HR game, and then it tacks on a paragraph from category 92 (batter season description) to give the player's current season stats. I agree that when the first message is about home runs, the second one should provide the season total. Otherwise, you get a disconnect.

Hmmm. The database doesn't contain an object numbered 2834, and none of the objects in category 24 has a number anywhere near that. (If there was a 2833 and a 2835, it would be easy to figure that this entry had been deleted recently, but it doesn't look like that happened.)

Object 1261 does contain the [%batting hr word] token, which should display the information you say was missing. I don't understand why you didn't see it. (Would have been helpful to show the actual text displayed, rather than just the debug numbers.)

However, I found a few other objects in category 92 that didn't mention home runs for the season, so I inserted the token and some text to cover it. Nice catch.

k

[battists]

Originally Posted by battists

I'll get Marc to post a new one.

It might be Monday though.

FYI, with the new patch due out this Friday, I've been asked to hold off on posting the updated XML. The Friday patch will have the updated XML.

Thanks!

Steve

[Tycobbler]

Nice !

[tysok]

I haven't been looking... but this one is so messed up I have to post it.

189-11393 Berryhill with a sweeping cut...
160-8347 check swing slow roller in front of the plate...
219-8814 hops on in to right...
221-11450 Berryhill is thinking two...
but quickly back to first for the single...

Okay... a sweeping cut that results in a check swing roller?
A check swing roller in front of the plate that hops on into right? And that's apparently hard enough that the batter is thinking two?

Sweeping cut: $20
Check swing roller hopping into right: $20
A pbp call that messed up: priceless.

[blackrussian]

Originally Posted by tysok

Okay... a sweeping cut that results in a check swing roller?
A check swing roller in front of the plate that hops on into right? And that's apparently hard enough that the batter is thinking two?

Sweeping cut: $20
Check swing roller hopping into right: $20
A pbp call that messed up: priceless.

maybe i'd believe it if hector villanueva was batting, but not berryhill

[jbsnadb]

Just in case there's time to sneak one more in:

[261-14376] with a good read cuts it off...

Somewhere in there, there should be a player name or position, I think. Ball was hit into right, BTW.